Open
Conversation
CheezItMan
reviewed
May 6, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Olga, I had one comment on heap_down and some on space complexity, but otherwise very nice work.
Comment on lines
+4
to
+6
| # Time Complexity: O(n log n) | ||
| # Space Complexity: O(n) | ||
| def heapsort(list) |
Comment on lines
+17
to
19
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(n) | ||
| def add(key, value = key) |
There was a problem hiding this comment.
👍 Why O(n) for space complexity, you add 1 element with this method.
Comment on lines
+26
to
28
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def remove() |
There was a problem hiding this comment.
👍 However for space complexity it's O(log n) because of the call stack.
Comment on lines
+51
to
53
| # Time complexity: O(1) | ||
| # Space complexity: O(1) | ||
| def empty? |
Comment on lines
+62
to
64
| # Time complexity: O(log n) | ||
| # Space complexity: O(1) | ||
| def heap_up(index) |
There was a problem hiding this comment.
👍 , but your space complexity is off due to recursion
| left_child = (index * 2) + 1 | ||
| right_child = (index * 2) + 2 | ||
|
|
||
| return if @store[left_child].nil? || @store[right_child].nil? |
There was a problem hiding this comment.
What about if the left child is not nil and the right child is?
Could you end up not making a swap you needed to? This is a rare but possible scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?